Reviewers: Mads Ager, Kevin Millikin,
Message:
While working on the strict mode delete I found that I can reorder the if
clauses for delete codegen and hopefully make the code slightly more
readable,
and I could also place assert I am introducing for the strict mode delete
work
in more general place:
var != NULL ==> cannot be in strict mode ==> ASSERT(strict_mode_flag() ==
kNonStrictMode)
Thank you!
Martin
Description:
Refactoring codegen for delete.
* keep handling of VariableProxy and Property together
* place clauses in the order of discovery
The refactoring is inspired by the strict mode delete changes.
While placing the ASSERT(strict_mode_flag() == kNonStrictMode)
for the variable case, I realized that better order of the if clauses
would make the code more readable, and also make it eas to place my assert.
BUG=
TEST=
Please review this at http://codereview.chromium.org/6475006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
M src/ia32/full-codegen-ia32.cc
M src/x64/full-codegen-x64.cc
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
