Reviewers: Mads Ager,
Description:
X64 Crankshaft: Add test that fails on x64 Crankshaft build to list of
skipped
mjsunit tests. Fix comments and remove unused function from date.js.
BUG=1153
TEST=mjsunit/date-parse
Please review this at http://codereview.chromium.org/6516011/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/date.js
M src/ia32/lithium-codegen-ia32.cc
M test/mjsunit/mjsunit.status
Index: src/date.js
===================================================================
--- src/date.js (revision 6771)
+++ src/date.js (working copy)
@@ -81,15 +81,10 @@
function InLeapYear(time) {
- return DaysInYear(YearFromTime(time)) == 366 ? 1 : 0;
+ return DaysInYear(YearFromTime(time)) - 365; // Returns 1 or 0.
}
-function DayWithinYear(time) {
- return DAY(time) - DayFromYear(YearFromTime(time));
-}
-
-
// ECMA 262 - 15.9.1.9
function EquivalentYear(year) {
// Returns an equivalent year in the range [2008-2035] matching
Index: src/ia32/lithium-codegen-ia32.cc
===================================================================
--- src/ia32/lithium-codegen-ia32.cc (revision 6771)
+++ src/ia32/lithium-codegen-ia32.cc (working copy)
@@ -1764,11 +1764,11 @@
Register object = ToRegister(instr->InputAt(0));
Register temp = ToRegister(instr->TempAt(0));
- // A Smi is not instance of anything.
+ // A Smi is not an instance of anything.
__ test(object, Immediate(kSmiTagMask));
__ j(zero, &false_result, not_taken);
- // This is the inlined call site instanceof cache. The two occourences
of the
+ // This is the inlined call site instanceof cache. The two occurences of
the
// hole value will be patched to the last map/result pair generated by
the
// instanceof stub.
NearLabel cache_miss;
@@ -1780,10 +1780,10 @@
__ mov(eax, Factory::the_hole_value()); // Patched to either true or
false.
__ jmp(&done);
- // The inlined call site cache did not match. Check null and string
before
- // calling the deferred code.
+ // The inlined call site cache did not match. Check for null and string
+ // before calling the deferred code.
__ bind(&cache_miss);
- // Null is not instance of anything.
+ // Null is not an instance of anything.
__ cmp(object, Factory::null_value());
__ j(equal, &false_result);
Index: test/mjsunit/mjsunit.status
===================================================================
--- test/mjsunit/mjsunit.status (revision 6771)
+++ test/mjsunit/mjsunit.status (working copy)
@@ -125,6 +125,9 @@
# BUG (1094)
regress/regress-deopt-gc: SKIP
+# BUG (1153)
+date-parse: SKIP
+
##############################################################################
[ $arch == mips ]
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
