Revision: 6775
Author: [email protected]
Date: Mon Feb 14 05:57:15 2011
Log: X64 Crankshaft: Add test that fails on x64 Crankshaft build to list of skipped mjsunit tests. Fix comments and remove unused function from date.js.

BUG=1153
TEST=mjsunit/date-parse
Review URL: http://codereview.chromium.org/6516011
http://code.google.com/p/v8/source/detail?r=6775

Modified:
 /branches/bleeding_edge/src/date.js
 /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc
 /branches/bleeding_edge/test/mjsunit/mjsunit.status

=======================================
--- /branches/bleeding_edge/src/date.js Fri Jan 28 02:33:10 2011
+++ /branches/bleeding_edge/src/date.js Mon Feb 14 05:57:15 2011
@@ -81,12 +81,7 @@


 function InLeapYear(time) {
-  return DaysInYear(YearFromTime(time)) == 366 ? 1 : 0;
-}
-
-
-function DayWithinYear(time) {
-  return DAY(time) - DayFromYear(YearFromTime(time));
+  return DaysInYear(YearFromTime(time)) - 365;  // Returns 1 or 0.
 }


=======================================
--- /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Fri Feb 11 06:34:02 2011 +++ /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Mon Feb 14 05:57:15 2011
@@ -1764,11 +1764,11 @@
   Register object = ToRegister(instr->InputAt(0));
   Register temp = ToRegister(instr->TempAt(0));

-  // A Smi is not instance of anything.
+  // A Smi is not an instance of anything.
   __ test(object, Immediate(kSmiTagMask));
   __ j(zero, &false_result, not_taken);

- // This is the inlined call site instanceof cache. The two occourences of the + // This is the inlined call site instanceof cache. The two occurences of the // hole value will be patched to the last map/result pair generated by the
   // instanceof stub.
   NearLabel cache_miss;
@@ -1780,10 +1780,10 @@
__ mov(eax, Factory::the_hole_value()); // Patched to either true or false.
   __ jmp(&done);

- // The inlined call site cache did not match. Check null and string before
-  // calling the deferred code.
+  // The inlined call site cache did not match. Check for null and string
+  // before calling the deferred code.
   __ bind(&cache_miss);
-  // Null is not instance of anything.
+  // Null is not an instance of anything.
   __ cmp(object, Factory::null_value());
   __ j(equal, &false_result);

=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Mon Feb 14 04:07:48 2011 +++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Mon Feb 14 05:57:15 2011
@@ -125,6 +125,9 @@
 # BUG (1094)
 regress/regress-deopt-gc: SKIP

+# BUG (1153)
+date-parse: SKIP
+
##############################################################################
 [ $arch == mips ]

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to