LGTM with one comment.
http://codereview.chromium.org/6520004/diff/2001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6520004/diff/2001/src/runtime.cc#newcode5856 src/runtime.cc:5856: bool ascii = separator->HasOnlyAsciiChars(); You will always need a TwoByteString. If everything is ascii then the %_FastAsciiArrayJoin call in the array.js file would have produced an ascii result already. I.e. you can safely remove the ascii variable and checks and inline the StringBuilderJoinHelper function. http://codereview.chromium.org/6520004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
