LGTM. This will also allow us to close issue http://code.google.com/p/v8/issues/detail?id=981
http://codereview.chromium.org/6524006/diff/1/src/ia32/builtins-ia32.cc File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/6524006/diff/1/src/ia32/builtins-ia32.cc#newcode752 src/ia32/builtins-ia32.cc:752: kSmiTagSize))); You can test directly against memory, without loading into ecx first, i.e., test(FieldOperand(ecx, SharedFunctionInfo::kCompilerHintsOffset), Immediate(...)); You might also want to use a byte-test ASSERT_EQ(8, SharedFunctionInfo::kStrictModeFunction); test_b(FieldOperand(ecx, ... + 1), Immediate((1 << (...)) >> 8); It would allow an 8-bit immediate instead of a 32-bit one. (Ditto for X64, with the appropriate differences for encoding). http://codereview.chromium.org/6524006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
