Revision: 6797
Author: [email protected]
Date: Tue Feb 15 08:12:46 2011
Log: Fix wrong assert in ia32 deoptimizer.

In revision 6795 I introduced an assertion in the deoptimizer that was
wrong. We check that curr_address - prev_address > patch_size(), but
prev_address is actually the address right after the last patched
call, so we just need to be larger than or equal to prev_address.


Review URL: http://codereview.chromium.org/6480068
http://code.google.com/p/v8/source/detail?r=6797

Modified:
 /branches/bleeding_edge/src/ia32/deoptimizer-ia32.cc

=======================================
--- /branches/bleeding_edge/src/ia32/deoptimizer-ia32.cc Tue Feb 15 06:36:12 2011 +++ /branches/bleeding_edge/src/ia32/deoptimizer-ia32.cc Tue Feb 15 08:12:46 2011
@@ -80,7 +80,7 @@
   Address prev_address = code_start_address;
   for (unsigned i = 0; i < table.length(); ++i) {
     Address curr_address = code_start_address + table.GetPcOffset(i);
-    ASSERT_GE(curr_address - prev_address, patch_size());
+    ASSERT_GE(curr_address, prev_address);
     ZapCodeRange(prev_address, curr_address);

     SafepointEntry safepoint_entry = table.GetEntry(i);

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to