Reviewers: Lasse Reichstein, Mads Ager,
Message:
Attempt at CallIC not wrapping "this" for strict mode target functions. Only
CallIC so far, not KeyedCallIC (though they call each other so parts may
actually work).
The idea is to delay ReceiverToObject call until we've had a chance to
sniff the
function being called. If non-strict, wrap, if strict, keep value as-is.
I need to poke around some more to see if I caught all cases but am hoping
for
early feedback.
Thank you!
Martin
http://codereview.chromium.org/6523052/diff/2001/src/ic.cc
File src/ic.cc (right):
http://codereview.chromium.org/6523052/diff/2001/src/ic.cc#newcode464
src/ic.cc:464: // TODO(mmaly): One cannot hang number-indexed functions
off of values, right?
I couldn't come up with a way where value could actually be valid here.
I may be wrong though...
Description:
CallIC not wrapping this for strict mode functions.
BUG=
TEST=
Please review this at http://codereview.chromium.org/6523052/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/stub-cache-arm.cc
M src/ia32/stub-cache-ia32.cc
M src/ic.cc
M src/x64/stub-cache-x64.cc
M test/mjsunit/strict-mode.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
