LGTM
http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc#newcode1719 src/arm/full-codegen-arm.cc:1719: __ tst(r1, Operand(0xc0000000)); Could we add a comment here. This is not completely obvious. This mask ensures that smi tagging will not overflow and that the result will be positive. Only needed if you shift by less than two. http://codereview.chromium.org/6529022/diff/1/src/arm/full-codegen-arm.cc#newcode1842 src/arm/full-codegen-arm.cc:1842: // Smi case. This code works the same way as the smi-smi case in the type I wonder if we can put these pieces of smi code in shared helper functions somehow. Seems silly to duplicate all this. Feel free to commit this, but we should see if we can share it. http://codereview.chromium.org/6529022/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
