Thanks a lot for review, Mads. Submitting.
http://codereview.chromium.org/6526016/diff/1006/src/top.cc
File src/top.cc (right):
http://codereview.chromium.org/6526016/diff/1006/src/top.cc#newcode938
src/top.cc:938: // When throwing the exception, we found no or another
v8::TryCatch
On 2011/02/16 09:17:49, Mads Ager wrote:
no or another -> no
Done.
http://codereview.chromium.org/6526016/diff/1006/src/top.cc#newcode961
src/top.cc:961: if (handler->is_try_finally()) return false;
On 2011/02/16 09:17:49, Mads Ager wrote:
In cases where the exception is propagated from the try-finally is
that handled
as a separate implicit throw at the end of the finally block?
In that case, please add a comment explaining that if the finally
clause does
not eat the exception (by returning for instance) it is rethrown at
the end of
the finally block.
Done.
http://codereview.chromium.org/6526016/diff/1006/src/top.h
File src/top.h (right):
http://codereview.chromium.org/6526016/diff/1006/src/top.h#newcode264
src/top.h:264: return
I find it more aesthetically pleasing to have this parallel structures,
but let's do it your way.
On 2011/02/16 09:17:49, Mads Ager wrote:
Why the extra line? I would probably do:
return ((exception != Failure::...) &&
(exception != Heap::...));
http://codereview.chromium.org/6526016/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
