Drive by comments.

http://codereview.chromium.org/6523052/diff/2001/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6523052/diff/2001/src/ic.cc#newcode511
src/ic.cc:511: ReceiverToObject(object);
1. Since this is now done after UpdateCaches, please fix
TryUpdateExtraICState. It assumes it's invoked with a wrapped receiver.

2. For builtin functions it would be nice to avoid wrapping the
receiver. It could be as simple as checking whether the function is a
builtin here. If turns out to be more involved feel free to ignore this
suggestion.

http://codereview.chromium.org/6523052/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to