Just FYI: We've got StrLength which casts its result to int (src/utils.h) On Wed, Feb 16, 2011 at 4:41 PM, <[email protected]> wrote: > Reviewers: Rico, > > Description: > Blargh. Yet another shot in the dark attempt to fix win64 compile. > > > BUG= > TEST= > > Please review this at http://codereview.chromium.org/6480116/ > > SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/out > > Affected files: > M test/cctest/test-parsing.cc > > > Index: test/cctest/test-parsing.cc > diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc > index > eadcaedb9d62410c61f2d826cb3c40e80c4ea6e8..8ee40385a6e19cc53bf0770be3cb7ac8d779c61d > 100755 > --- a/test/cctest/test-parsing.cc > +++ b/test/cctest/test-parsing.cc > @@ -321,15 +321,17 @@ TEST(Regress928) { > > data->Initialize(); > > - intptr_t first_function = strstr(program, "function") - program; > - intptr_t first_lbrace = first_function + strlen("function () "); > + int first_function = > + static_cast<int>(strstr(program, "function") - program); > + int first_lbrace = first_function + static_cast<int>(strlen("function () > ")); > CHECK_EQ('{', program[first_lbrace]); > i::FunctionEntry entry1 = data->GetFunctionEntry(first_lbrace); > CHECK(!entry1.is_valid()); > > - intptr_t second_function = > - strstr(program + first_lbrace, "function") - program; > - intptr_t second_lbrace = second_function + strlen("function () "); > + int second_function = > + static_cast<int>(strstr(program + first_lbrace, "function") - > program); > + int second_lbrace = > + second_function + static_cast<int>(strlen("function () ")); > CHECK_EQ('{', program[second_lbrace]); > i::FunctionEntry entry2 = data->GetFunctionEntry(second_lbrace); > CHECK(entry2.is_valid()); > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
