LGTM
http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc#newcode3464 src/x64/code-stubs-x64.cc:3464: // None of the flags is supported on X64. is -> are http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1607 src/x64/lithium-codegen-x64.cc:1607: NearLabel true_value, done; Maybe put labels above the testq minimize diff to ia32 http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1664 src/x64/lithium-codegen-x64.cc:1664: // Here result has either true or false. Deferred code also produces true or it never has true here does it? http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc#newcode1085 src/x64/lithium-x64.cc:1085: UseFixed(instance_of->right()), rdx); is the parenthesis not in the wrong place above? rdx is the fixed register we should use right? Does this even compile? http://codereview.chromium.org/6529024/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
