Reviewers: Rico,
http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/code-stubs-x64.cc#newcode3464 src/x64/code-stubs-x64.cc:3464: // None of the flags is supported on X64. On 2011/02/16 14:43:25, Rico wrote:
is -> are
Done. http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1607 src/x64/lithium-codegen-x64.cc:1607: NearLabel true_value, done; On 2011/02/16 14:43:25, Rico wrote:
Maybe put labels above the testq minimize diff to ia32
Done. http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1664 src/x64/lithium-codegen-x64.cc:1664: // Here result has either true or false. Deferred code also produces true or Comment deleted. On 2011/02/16 14:43:25, Rico wrote:
it never has true here does it?
http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc File src/x64/lithium-x64.cc (right): http://codereview.chromium.org/6529024/diff/3001/src/x64/lithium-x64.cc#newcode1085 src/x64/lithium-x64.cc:1085: UseFixed(instance_of->right()), rdx); On 2011/02/16 14:43:25, Rico wrote:
is the parenthesis not in the wrong place above? rdx is the fixed
register we
should use right? Does this even compile?
This was a last minute change. This is dead code, but it didn't compile until I fixed it. Description: X64 Crankshaft: Implement InstanceOf and InstanceOfKnownGlobal Please review this at http://codereview.chromium.org/6529024/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/x64/code-stubs-x64.cc M src/x64/lithium-codegen-x64.h M src/x64/lithium-codegen-x64.cc M src/x64/lithium-x64.h M src/x64/lithium-x64.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
