http://codereview.chromium.org/6524039/diff/2001/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/6524039/diff/2001/src/runtime.cc#newcode7218 src/runtime.cc:7218: } It *would* be better to catch those syntax errors earlier, and it might not be a breaking change since both Webkit Nightlies and Firefox 4.0 betas are already doing it. With the current preparsing there are syntax errors that we cannot catch at preparse-time (e.g., "continue x" where x isn't the label of a loop, because we record neither labels nor loops during preparsing). We can't catch those until the function is parsed properly the first time, and if it's lazy, that might be when it's attempted inlined. Another option is to make uncompiled functions not optimizable. Currently when we check if we can optimize a function, if it's uncompiled we optimistically assume that it is. Changed to using ReplaceCode. http://codereview.chromium.org/6524039/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
