LGTM. It's sort of ugly that "const" crosscuts so many different parts of the VM.
http://codereview.chromium.org/6519050/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6519050/diff/1/src/runtime.cc#newcode1085 src/runtime.cc:1085: if (lookup.IsProperty()) { I think you can now write this as: if (lookup.IsProperty() && lookup.type() != INTERCEPTOR && (lookup.IsReadOnly() || is_const_property)) { const char* type = (lookup.IsReadOnly()) ? "const" : "var"; return ThrowRedeclarationError(type, name); } RETURN_IF_EMPTY_HANDLE(SetProperty(.....)); http://codereview.chromium.org/6519050/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
