LGTM

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):

http://codereview.chromium.org/6542011/diff/4002/src/ia32/lithium-ia32.cc#newcode1981
src/ia32/lithium-ia32.cc:1981: return NULL;
What is the "value" that is never used?
Is this function never called, or is its return value never used (and if
so, how do we know that)?
If it's never called, it should either assert that, or do a bailout if
it ever got called anyway.
If the return value isn't used, why are we calling the function?

http://codereview.chromium.org/6542011/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to