Reviewers: Kevin Millikin,
Message:
Kevin,
another tiny review for you
Description:
Minor refactoring: unify lazy function compilation for in loop and no in
loop
variants.
Please review this at http://codereview.chromium.org/6542017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/handles.cc
Index: src/handles.cc
diff --git a/src/handles.cc b/src/handles.cc
index
d625d644c776e744251d69bfc7f582b77751c1b2..cdd33e309af58720216e1e147bfd937345127c3d
100644
--- a/src/handles.cc
+++ b/src/handles.cc
@@ -834,14 +834,16 @@ bool CompileLazyShared(Handle<SharedFunctionInfo>
shared,
}
-bool CompileLazy(Handle<JSFunction> function,
- ClearExceptionFlag flag) {
+static bool CompileLazyFunction(Handle<JSFunction> function,
+ ClearExceptionFlag flag,
+ bool in_loop) {
bool result = true;
if (function->shared()->is_compiled()) {
function->ReplaceCode(function->shared()->code());
function->shared()->set_code_age(0);
} else {
CompilationInfo info(function);
+ if (in_loop) info.MarkAsInLoop();
result = CompileLazyHelper(&info, flag);
ASSERT(!result || function->is_compiled());
}
@@ -852,22 +854,15 @@ bool CompileLazy(Handle<JSFunction> function,
}
+bool CompileLazy(Handle<JSFunction> function,
+ ClearExceptionFlag flag) {
+ return CompileLazyFunction(function, flag, false /* in loop */);
+}
+
+
bool CompileLazyInLoop(Handle<JSFunction> function,
ClearExceptionFlag flag) {
- bool result = true;
- if (function->shared()->is_compiled()) {
- function->ReplaceCode(function->shared()->code());
- function->shared()->set_code_age(0);
- } else {
- CompilationInfo info(function);
- info.MarkAsInLoop();
- result = CompileLazyHelper(&info, flag);
- ASSERT(!result || function->is_compiled());
- }
- if (result && function->is_compiled()) {
- PROFILE(FunctionCreateEvent(*function));
- }
- return result;
+ return CompileLazyFunction(function, flag, true /* in loop */);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
