LGTM

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-codegen-x64.cc#newcode2034
src/x64/lithium-codegen-x64.cc:2034: Register scratch =
ToRegister(instr->TempAt(0));
Can't we use our normal kScratchRegister here?

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/6469053/diff/1/src/x64/lithium-x64.h#newcode471
src/x64/lithium-x64.h:471: LOperand* temp) {
See comment in codegen, can't we just use kScratchRegister?

http://codereview.chromium.org/6469053/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to