I've updated the CL with a bug fix for the kFindFirst mode of operation.
This
breaks the previous found_target_ flag into found_target_ and
found_target_in_trace_ flags.
http://codereview.chromium.org/6541044/diff/1003/src/heap.h
File src/heap.h (right):
http://codereview.chromium.org/6541044/diff/1003/src/heap.h#newcode2173
src/heap.h:2173: found_target_in_trace_(false),
There's a need to distinguish found_target_in_trace_ from the global
found_target_ because VisitPointers() is called for the range of one
pointer at a time. This exposes a bug where TracePathFrom() needs to
reset the found flag for the current trace, but we also need a global
flag to indicate whether the target was found at all. This wasn't a
problem before because we did not support the kFindFirst mode
previously.
The solution is to separate these 2 found flags where
found_target_in_trace_ tracks whether the target was found in the
current trace path, and found_target_ tracks whether the target was
found at all.
http://codereview.chromium.org/6541044/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
