http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc#newcode1260 src/arm/stub-cache-arm.cc:1260: __ push(name_reg); __ Push(receiver, scratch3, name_reg) (or at least __ Push(scratch3, name_reg)) apparently should work and save one instruction. http://codereview.chromium.org/6462029/diff/1/src/arm/stub-cache-arm.cc#newcode1268 src/arm/stub-cache-arm.cc:1268: __ str(scratch2, MemOperand(sp, 1 * kPointerSize)); Is is an instance of v8::AccessorInfo which consists of a single pointer internal::Object** args_. Not too hard to conclude from the next comment but may be worth to mention. On 2011/02/17 16:13:44, antonm wrote:
Please, explain briefly why we need additional wrapping here.
BTW, is this ABI universal across ARM compilers?
http://codereview.chromium.org/6462029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
