http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc File src/platform-linux.cc (right):
http://codereview.chromium.org/6543039/diff/1/src/platform-linux.cc#newcode330 src/platform-linux.cc:330: FILE* file = fopen(name, "a+"); I don't think "a+" is the right flag. If you plan to read and write to the file from the beginning, and avoid truncating it, then you should use "r+". This concern has arisen to me because in 'mmap' you pass 0 as the offset inside the file, which contradicts with the "a" flag semantics that means appending data to a file. Thus, using both "a" and "0" offset seems like a contradiction. Also, you don't pass 'FILE_APPEND_DATA' to the Win32 function, so I'm concluding you really don't want to append to the file. http://codereview.chromium.org/6543039/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
