LGTM with the comment addressed.
http://codereview.chromium.org/5966001/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/5966001/diff/1/src/heap.cc#newcode3763 src/heap.cc:3763: static unsigned int last_gc_count = gc_count_; There is a bug here: last_gc_count will be initialized once (on the first invocation of IdleNotification) with gc_count_ value and will not be reinitialized again so it will always remain the same. Please split this into declaration and assignment. And thanks for making me notice this place. http://codereview.chromium.org/5966001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
