Revision: 6873
Author: [email protected]
Date: Mon Feb 21 10:28:20 2011
Log: Minor refactoring: unify lazy function compilation for in loop and no
in loop variants.
Review URL: http://codereview.chromium.org/6542017
http://code.google.com/p/v8/source/detail?r=6873
Modified:
/branches/bleeding_edge/src/handles.cc
=======================================
--- /branches/bleeding_edge/src/handles.cc Thu Feb 17 06:13:25 2011
+++ /branches/bleeding_edge/src/handles.cc Mon Feb 21 10:28:20 2011
@@ -834,14 +834,16 @@
}
-bool CompileLazy(Handle<JSFunction> function,
- ClearExceptionFlag flag) {
+static bool CompileLazyFunction(Handle<JSFunction> function,
+ ClearExceptionFlag flag,
+ InLoopFlag in_loop_flag) {
bool result = true;
if (function->shared()->is_compiled()) {
function->ReplaceCode(function->shared()->code());
function->shared()->set_code_age(0);
} else {
CompilationInfo info(function);
+ if (in_loop_flag == IN_LOOP) info.MarkAsInLoop();
result = CompileLazyHelper(&info, flag);
ASSERT(!result || function->is_compiled());
}
@@ -850,24 +852,17 @@
}
return result;
}
+
+
+bool CompileLazy(Handle<JSFunction> function,
+ ClearExceptionFlag flag) {
+ return CompileLazyFunction(function, flag, NOT_IN_LOOP);
+}
bool CompileLazyInLoop(Handle<JSFunction> function,
ClearExceptionFlag flag) {
- bool result = true;
- if (function->shared()->is_compiled()) {
- function->ReplaceCode(function->shared()->code());
- function->shared()->set_code_age(0);
- } else {
- CompilationInfo info(function);
- info.MarkAsInLoop();
- result = CompileLazyHelper(&info, flag);
- ASSERT(!result || function->is_compiled());
- }
- if (result && function->is_compiled()) {
- PROFILE(FunctionCreateEvent(*function));
- }
- return result;
+ return CompileLazyFunction(function, flag, IN_LOOP);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
