LGTM
http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/6469083/diff/1/src/arm/full-codegen-arm.cc#newcode3376 src/arm/full-codegen-arm.cc:3376: // (but "delete this" is). Remove the parenthesis? but "delete this" is allowed. http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/6469083/diff/1/src/ia32/codegen-ia32.cc#newcode8260 src/ia32/codegen-ia32.cc:8260: frame_->Push(Factory::false_value()); On 2011/02/21 20:18:36, Martin Maly wrote:
aligning the code layout of ia32, x64 and arm codegens, they were
inconsistent. Thanks. http://codereview.chromium.org/6469083/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
