OK. I get the point :-)
http://codereview.chromium.org/6532087/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95 src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix == 0) { On 2011/02/22 08:53:05, Erik Corry wrote:
I think you want === here.
Done. http://codereview.chromium.org/6532087/diff/1/src/v8natives.js#newcode95 src/v8natives.js:95: if (IS_UNDEFINED(radix) || radix == 10 || radix == 0) { On 2011/02/22 08:53:55, Mads Ager wrote:
Erik suggests using === here. I agree with that and we should do so
below as
well (the checks before %_GetCachedArrayIndex).
Done. http://codereview.chromium.org/6532087/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
