[v8-dev] [v8] r6906 committed - x64: Implement context stores and loads, unknown osr value, and osr...

[codesite-noreply]

Revision: 6906
Author: a...@chromium.org
Date: Wed Feb 23 01:51:53 2011
Log: x64: Implement context stores and loads, unknown osr value, and osr
entry in lithium backend.
Review URL: http://codereview.chromium.org/6566002
http://code.google.com/p/v8/source/detail?r=6906

Modified:
 /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc
 /branches/bleeding_edge/src/x64/lithium-x64.cc
 /branches/bleeding_edge/src/x64/lithium-x64.h

=======================================
--- /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc	Tue Feb 22  
08:56:57 2011
+++ /branches/bleeding_edge/src/x64/lithium-codegen-x64.cc	Wed Feb 23  
01:51:53 2011
@@ -1906,7 +1906,20 @@


 void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) {
-  Abort("Unimplemented: %s", "DoLoadContextSlot");
+  Register context = ToRegister(instr->context());
+  Register result = ToRegister(instr->result());
+  __ movq(result, ContextOperand(context, instr->slot_index()));
+}
+
+
+void LCodeGen::DoStoreContextSlot(LStoreContextSlot* instr) {
+  Register context = ToRegister(instr->context());
+  Register value = ToRegister(instr->value());
+  __ movq(ContextOperand(context, instr->slot_index()), value);
+  if (instr->needs_write_barrier()) {
+    int offset = Context::SlotOffset(instr->slot_index());
+    __ RecordWrite(context, offset, value, kScratchRegister);
+  }
 }


=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.cc      Tue Feb 22 06:40:13 2011
+++ /branches/bleeding_edge/src/x64/lithium-x64.cc      Wed Feb 23 01:51:53 2011
@@ -294,6 +294,13 @@
   InputAt(0)->PrintTo(stream);
   stream->Add("[%d]", slot_index());
 }
+
+
+void LStoreContextSlot::PrintDataTo(StringStream* stream) {
+  InputAt(0)->PrintTo(stream);
+  stream->Add("[%d] <- ", slot_index());
+  InputAt(1)->PrintTo(stream);
+}


 void LCallKeyed::PrintDataTo(StringStream* stream) {
@@ -1679,14 +1686,22 @@


 LInstruction* LChunkBuilder::DoLoadContextSlot(HLoadContextSlot* instr) {
-  Abort("Unimplemented: %s", "DoLoadContextSlot");
-  return NULL;
+  LOperand* context = UseRegisterAtStart(instr->value());
+  return DefineAsRegister(new LLoadContextSlot(context));
 }


 LInstruction* LChunkBuilder::DoStoreContextSlot(HStoreContextSlot* instr) {
-  Abort("Unimplemented: DoStoreContextSlot");
-  return NULL;
+  LOperand* context;
+  LOperand* value;
+  if (instr->NeedsWriteBarrier()) {
+    context = UseTempRegister(instr->context());
+    value = UseTempRegister(instr->value());
+  } else {
+    context = UseRegister(instr->context());
+    value = UseRegister(instr->value());
+  }
+  return new LStoreContextSlot(context, value);
 }


@@ -1874,8 +1889,9 @@


 LInstruction* LChunkBuilder::DoOsrEntry(HOsrEntry* instr) {
-  Abort("Unimplemented: %s", "DoOsrEntry");
-  return NULL;
+  allocator_->MarkAsOsrEntry();
+  current_block_->last_environment()->set_ast_id(instr->ast_id());
+  return AssignEnvironment(new LOsrEntry);
 }


@@ -1886,8 +1902,8 @@


 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
-  Abort("Unimplemented: %s", "DoUnknownOSRValue");
-  return NULL;
+  int spill_index = chunk()->GetNextSpillIndex(false);  // Not  
double-width.
+  return DefineAsSpilled(new LUnknownOSRValue, spill_index);
 }


=======================================
--- /branches/bleeding_edge/src/x64/lithium-x64.h       Tue Feb 22 06:40:13 2011
+++ /branches/bleeding_edge/src/x64/lithium-x64.h       Wed Feb 23 01:51:53 2011
@@ -141,6 +141,7 @@
   V(SmiTag)                                     \
   V(SmiUntag)                                   \
   V(StackCheck)                                 \
+  V(StoreContextSlot)                           \
   V(StoreGlobal)                                \
   V(StoreKeyedFastElement)                      \
   V(StoreKeyedGeneric)                          \
@@ -1241,6 +1242,25 @@

   LOperand* context() { return InputAt(0); }
   int slot_index() { return hydrogen()->slot_index(); }
+
+  virtual void PrintDataTo(StringStream* stream);
+};
+
+
+class LStoreContextSlot: public LTemplateInstruction<0, 2, 0> {
+ public:
+  LStoreContextSlot(LOperand* context, LOperand* value) {
+    inputs_[0] = context;
+    inputs_[1] = value;
+  }
+
+  DECLARE_CONCRETE_INSTRUCTION(StoreContextSlot, "store-context-slot")
+  DECLARE_HYDROGEN_ACCESSOR(StoreContextSlot)
+
+  LOperand* context() { return InputAt(0); }
+  LOperand* value() { return InputAt(1); }
+  int slot_index() { return hydrogen()->slot_index(); }
+  int needs_write_barrier() { return hydrogen()->NeedsWriteBarrier(); }

   virtual void PrintDataTo(StringStream* stream);
 };

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev