On 2011/02/23 11:22:36, Lasse Reichstein wrote:
LGTM
http://codereview.chromium.org/6568004/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
We do this at some other place, but, since the Typeof code is based
on jumps, it does not help much here.
http://codereview.chromium.org/6568004/diff/1/src/x64/lithium-codegen-x64.cc#newcode3207
src/x64/lithium-codegen-x64.cc:3207: __ LoadRoot(result,
Heap::kTrueValueRootIndex);
Would it be faster to make a macro for loading true/false that uses the
fact
that they are adjacent in the root array?
I.e., something like
setcc(condition, kScratchRegister);
movzxbl(kScratchRegister, kScratchRegister);
movq(result, Operand(kRootRegister, kScratchRegister, times_pointer_size,
Heap::kTrueValueRootIndex * kPointerSize);
That would avoid the conditional jumps (which, in this case, wouldn't
help us
since the EmitTypeofIs already uses labels for control, so that would
need to
be
changed too).
http://codereview.chromium.org/6568004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
