Thanks for fixing this, Anton. I remember wondering when I made the change
from
Runtime::GetObjectProperty (returns MaybeObject*) to GetProperty (returhs
Handle<Object>) whether something may be different. Now re-reading
CALL_HEAP_FUNCTION it makes sense that on exception empty handle gets
returned
which requires your code to propagate it out.
LGTM. Mads may want to double-check, although I am pretty sure this is the
right
fix..
Thanks again
Martin
http://codereview.chromium.org/6580030/diff/1/src/ic.cc
File src/ic.cc (right):
http://codereview.chromium.org/6580030/diff/1/src/ic.cc#newcode807
src/ic.cc:807: RETURN_IF_EMPTY_HANDLE(result);
Of course ... with my recent change the exceptions were getting lost
here. Thanks for fixing it!
http://codereview.chromium.org/6580030/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
