Reviewers: Mads Ager, Jungshik Shin, Message: Mads, please take a close look at MakeWeak/Delete logic.
Also, I would like to check with you if I understand HandleScope properly: 1. If I do any of ::New or NewInstance and those are local vars (not to be returned) I should always use HandleScope for auto cleanup. 2. Plain returns of say v8::String::New(...) don't need HandleScope::Close(allocated-string) 3. If HandleScope is used, then I need to call Close(var) for any variable I would like to return back to the caller. Does that sound good? Jungshik please take a look at i18n stuff. Description: Adding break iterator support to the i18n api extension. This is vendor specific, and is prefixed by v8. WebKit layout tests will be added in a separate CL. Please review this at http://codereview.chromium.org/6598014/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: A src/extensions/experimental/break-iterator.h A src/extensions/experimental/break-iterator.cc M src/extensions/experimental/experimental.gyp M src/extensions/experimental/i18n-extension.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
