Comments addressed, please take another look
http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.cc#newcode526 src/x64/lithium-codegen-x64.cc:526: JumpTableEntry* jump_info = new JumpTableEntry(); On 2011/02/28 08:42:30, Lasse Reichstein wrote:
Can we generate the same jump more than once? (I.e., is there anything
to save
by recognizing it and making only one entry in the jump-table).
Done. http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.cc#newcode527 src/x64/lithium-codegen-x64.cc:527: jump_info->address = entry; On 2011/02/28 08:42:30, Lasse Reichstein wrote:
Set this in a constructor.
Done. http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.h File src/x64/lithium-codegen-x64.h (right): http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.h#newcode56 src/x64/lithium-codegen-x64.h:56: jump_table_(4), On 2011/02/28 08:42:30, Lasse Reichstein wrote:
If possible, remove the 4 (and the 4 above). Just rely on the ZoneList
default
initial capacity (which, IIRC, happens to be 4).
There is no default ZoneList constructor http://codereview.chromium.org/6596032/diff/1/src/x64/lithium-codegen-x64.h#newcode239 src/x64/lithium-codegen-x64.h:239: struct JumpTableEntry { On 2011/02/28 08:42:30, Lasse Reichstein wrote:
Have a constructor to initialize label and address.
Done. http://codereview.chromium.org/6596032/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
