http://codereview.chromium.org/6594037/diff/1/src/ic.h File src/ic.h (right):
http://codereview.chromium.org/6594037/diff/1/src/ic.h#newcode436 src/ic.h:436: ASSERT(code->extra_ic_state() == target()->extra_ic_state()); On 2011/02/28 11:18:30, Lasse Reichstein wrote:
If the "extra_ic_state" is only strict/non-strict, just call it
strict_ic_state
and return the correct enum value directly. The way you use it seems
to assume
that the value is exactly kStrictMode. If we ever need more state, we can add more accessors.
Please don't kill extra_ic_state. It's also used as an opaque extra state to gather more type feedback. But having another accessor that wraps it is a probably a good idea. http://codereview.chromium.org/6594037/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
