LGTM.

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#newcode3209
src/arm/full-codegen-arm.cc:3209: // We will leave the separator on the
stack until the end of the function.
This comment seems inconsistent with the "pop separator" line below.

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#newcode3327
src/arm/full-codegen-arm.cc:3327: // Live values in registers:
array_length must be live here, because you use it below.

http://codereview.chromium.org/6594071/diff/2002/src/arm/full-codegen-arm.cc#newcode3402
src/arm/full-codegen-arm.cc:3402: // labe long_separator below.
label

http://codereview.chromium.org/6594071/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to