LGTM with comments.
http://codereview.chromium.org/6596073/diff/1/src/profile-generator.h File src/profile-generator.h (right): http://codereview.chromium.org/6596073/diff/1/src/profile-generator.h#newcode884 src/profile-generator.h:884: class HeapEntriesMap { Consider refactoring it into a simple HeapThing->EntryInfo map and a wrapper that does things like Pair on top of it. http://codereview.chromium.org/6596073/diff/1/src/profile-generator.h#newcode894 src/profile-generator.h:894: void UpdateEntries(); The name is confusing. It's supposed to be called only once (if I got it right) to actually create the entries. http://codereview.chromium.org/6596073/diff/1/src/profile-generator.h#newcode994 src/profile-generator.h:994: HeapEntry* AllocateEntry( It seems weird to have both AllocateEntry and AddEntry in the public interface. The latter should be hidden. Also please mark the function as virtual to make it clearer it's an interface implementation. http://codereview.chromium.org/6596073/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
