Thanks. I kept the comments long for educational purposes :)
http://codereview.chromium.org/6598014/diff/6013/src/extensions/experimental/break-iterator.cc File src/extensions/experimental/break-iterator.cc (right): http://codereview.chromium.org/6598014/diff/6013/src/extensions/experimental/break-iterator.cc#newcode54 src/extensions/experimental/break-iterator.cc:54: // First delete the hidden C++ object. Deleting NULL is ok. On 2011/03/01 18:58:32, Mads Ager wrote:
Unpacking should never give NULL here. That will only happen if you
use this as
the weak callback for persistent handles not pointing to a break
iterator. Maybe
update the comment with that info instead?
Done. http://codereview.chromium.org/6598014/diff/6013/src/extensions/experimental/break-iterator.cc#newcode61 src/extensions/experimental/break-iterator.cc:61: // Returns a ThrowException value in case we encounter invalid On 2011/03/01 18:58:32, Mads Ager wrote:
ThrowException returns undefined and schedules an exception to be
thrown (which
means that the undefined is ignored and the stack unwinded). Change
the comment:
"Returns a ThrowEception value" -> "Throws an exception"?
Done. http://codereview.chromium.org/6598014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
