http://codereview.chromium.org/6596104/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/6596104/diff/1/src/x64/lithium-codegen-x64.cc#newcode1641
src/x64/lithium-codegen-x64.cc:1641:
Immediate(String::kContainsCachedArrayIndexMask));
On 2011/03/02 09:59:07, Lasse Reichstein wrote:
Indentation.
Done.
http://codereview.chromium.org/6596104/diff/1/src/x64/lithium-codegen-x64.cc#newcode1644
src/x64/lithium-codegen-x64.cc:1644: __ LoadRoot(result,
Heap::kFalseValueRootIndex);
On 2011/03/02 09:59:07, Lasse Reichstein wrote:
Could we do just one computed load from the root array here?
E.g.
ASSERT(Heap::kTrueValueRootIndex + 1 == Heap::kFalseValueRootIndex);
__ setcc(zero, result);
__ movzxbl(result, result);
__ LoadRoot(result, result, Heap::kTrueValueRootIndex);
(adding a
void LoadRoot(Register dst, Register dynIdx, int idx) {
__ movq(dst, Operand(kRootRegister, dynIdx, times_pointer_size,
idx *
kPointerSize);
}
if it's not there already).
I think we use similar code elsewhere.
As discussed offline this will not really have any effect here, leaving
it as is to be consistent with the remainder of the lithium
instructions.
http://codereview.chromium.org/6596104/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
