LGTM
http://codereview.chromium.org/6597104/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6597104/diff/1/src/heap.h#newcode1159 src/heap.h:1159: // Returns the size of object residing in non new spaces. object -> the objects http://codereview.chromium.org/6597104/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6597104/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1959 src/ia32/lithium-codegen-ia32.cc:1959: object, value, scratch, INLINE_SMI_CHECK, DESTROY_OBJECT, DESTROY_VALUE, DESTROY_SCRATCH); Lint. http://codereview.chromium.org/6597104/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/6597104/diff/1/src/ia32/macro-assembler-ia32.cc#newcode74 src/ia32/macro-assembler-ia32.cc:74: if (preserve[i]) push(Register::from_code(i)); SSE2 registers? http://codereview.chromium.org/6597104/diff/1/src/ia32/macro-assembler-ia32.cc#newcode86 src/ia32/macro-assembler-ia32.cc:86: Extra blank line. http://codereview.chromium.org/6597104/diff/1/src/ia32/macro-assembler-ia32.cc#newcode115 src/ia32/macro-assembler-ia32.cc:115: Extra blank line. http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc File src/incremental-marking.cc (right): http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc#newcode130 src/incremental-marking.cc:130: static const intptr_t kActivationThreshold = 0; Perhaps worth setting this to some low level so that some debug tests run with incremental marking and some without. http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc#newcode138 src/incremental-marking.cc:138: static void PatchStubs(bool enable) { This should be called something that reveals what sort of stubs it patches. http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc#newcode141 src/incremental-marking.cc:141: Blank line. http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc#newcode152 src/incremental-marking.cc:152: e = JSGlobalPropertyCell::cast(e)->value(); WTF? http://codereview.chromium.org/6597104/diff/1/src/incremental-marking.cc#newcode157 src/incremental-marking.cc:157: *stub->instruction_start() = enable ? 0x90 : 0xc3; These should be constants from assembler-ia32.h Also you should assert that the old value was the opposite. http://codereview.chromium.org/6597104/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
