LGTM, thanks!
http://codereview.chromium.org/6606002/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6606002/diff/1/src/runtime.cc#newcode11317 src/runtime.cc:11317: HandleScope scope; It's not performance critical, but just for consistency please use "HandleScope scope(isolate)" in runtime.cc. http://codereview.chromium.org/6606002/diff/4007/src/ast.cc File src/ast.cc (right): http://codereview.chromium.org/6606002/diff/4007/src/ast.cc#newcode255 src/ast.cc:255: Handle<Object> key_handle = FACTORY->NewNumberFromUint(hash); Given the number of FACTORY usages here it might make sense to cache it. http://codereview.chromium.org/6606002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
