Rubberstamp LGTM. I only looked into isolate.{h,cc}.
http://codereview.chromium.org/6606006/diff/1/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/6606006/diff/1/src/isolate.cc#newcode188
src/isolate.cc:188: Isolate::RunStaticInitializers();
Consider doing this before the default isolate is pre-inited.
http://codereview.chromium.org/6606006/diff/1/src/isolate.h
File src/isolate.h (right):
http://codereview.chromium.org/6606006/diff/1/src/isolate.h#newcode942
src/isolate.h:942: // Used to init the structures that are "const after
they are niitialized
Typo "niitialized".
http://codereview.chromium.org/6606006/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev