Reviewers: Lasse Reichstein, Mads Ager, Message: The remainder of the 'assignment to read only property" implementation - SetElement.
Thank you! Martin http://codereview.chromium.org/6613005/diff/2001/src/debug.cc File src/debug.cc (right): http://codereview.chromium.org/6613005/diff/2001/src/debug.cc#newcode1019 src/debug.cc:1019: kNonStrictMode); Debugger code, not using strict mode. http://codereview.chromium.org/6613005/diff/2001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6613005/diff/2001/src/runtime.cc#newcode8675 src/runtime.cc:8675: SetElement(jsobject, index1, tmp2, kNonStrictMode); Runtime_SwapElements - used by quick sort. I couldn't find any mention that the array sorting should behave strictly so I am keeping it non-strict. http://codereview.chromium.org/6613005/diff/2001/src/runtime.cc#newcode11502 src/runtime.cc:11502: SetElement(result, index++, pair, kNonStrictMode); \ Debug code only, no need for strict mode. http://codereview.chromium.org/6613005/diff/2002/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/6613005/diff/2002/src/handles.cc#newcode269 src/handles.cc:269: object, key, value, attributes), fixed the whitespace :) Description: Implementation of strict mode in SetElement. Passing strict mode throughout SetElement. Throw if assigning to read only element. Adding tests for element assignment in strict mode. Fix tests for strict mode SetElement. BUG=http://code.google.com/p/v8/issues/detail?id=1220 TEST=test/mjsunit/strict-mode.js Please review this at http://codereview.chromium.org/6613005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/api.cc M src/debug.cc M src/handles.h M src/handles.cc M src/ic.cc M src/jsregexp.cc M src/liveedit.cc M src/objects.h M src/objects.cc M src/parser.cc M src/runtime.cc M src/type-info.cc M test/cctest/test-api.cc M test/cctest/test-heap.cc M test/mjsunit/strict-mode.js -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
