LGTM
We need a name that makes it more clear. Also, you should comment that you
*have
to* use 'new' to get one of these constructed. I would prefer if we can
find a
way to make sure that the 'new' keyword was not required.
http://codereview.chromium.org/6602081/diff/13/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
http://codereview.chromium.org/6602081/diff/13/src/arm/builtins-arm.cc#newcode431
src/arm/builtins-arm.cc:431: // Initial map for the builtin Array
functions shoud be maps.
shoud -> should
http://codereview.chromium.org/6602081/diff/13/src/array.js
File src/array.js (right):
http://codereview.chromium.org/6602081/diff/13/src/array.js#newcode1233
src/array.js:1233: // The internal Array prototype doesn't need to be
fancy, since it's never
I would like the difference to be more clear. $Array vs Array is subtle.
Array -> InternalArray or something like that.
http://codereview.chromium.org/6602081/diff/13/src/array.js#newcode1238
src/array.js:1238: Array.prototype = new $Object();
Do you need this one? Don't you already set this in the setup code for
the builtins object?
http://codereview.chromium.org/6602081/diff/13/src/bootstrapper.cc
File src/bootstrapper.cc (right):
http://codereview.chromium.org/6602081/diff/13/src/bootstrapper.cc#newcode1243
src/bootstrapper.cc:1243: { // --- B u i l t - i n A r r a y ---
Builtin -> Internal?
http://codereview.chromium.org/6602081/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
