Reviewers: William Hesse,
Description:
Remove tests for being the normal array constructor from the
ArrayConstructCode
builtin.
Please review this at http://codereview.chromium.org/6613016/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32
Affected files:
M src/arm/builtins-arm.cc
M src/x64/builtins-x64.cc
Index: src/arm/builtins-arm.cc
diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc
index
169bc6bf8535a285a78e66d0a13f7541c28e6c22..961d3ce5b981e830d95bbc9c35e53e66d4edfde9
100644
--- a/src/arm/builtins-arm.cc
+++ b/src/arm/builtins-arm.cc
@@ -458,11 +458,8 @@ void
Builtins::Generate_ArrayConstructCode(MacroAssembler* masm) {
Label generic_constructor;
if (FLAG_debug_code) {
- // The array construct code is only set for the builtin Array function
which
- // always have a map.
- GenerateLoadArrayFunction(masm, r2);
- __ cmp(r1, r2);
- __ Assert(eq, "Unexpected Array function");
+ // The array construct code is only set for the builtin and internal
+ // Array functions which always have a map.
// Initial map for the builtin Array function should be a map.
__ ldr(r2, FieldMemOperand(r1,
JSFunction::kPrototypeOrInitialMapOffset));
__ tst(r2, Operand(kSmiTagMask));
Index: src/x64/builtins-x64.cc
diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc
index
419179274c3a40a8531776c97a9415c43c3df1f9..b545876e21cda738e2ad0bbdf517f144734793c9
100644
--- a/src/x64/builtins-x64.cc
+++ b/src/x64/builtins-x64.cc
@@ -1280,11 +1280,8 @@ void
Builtins::Generate_ArrayConstructCode(MacroAssembler* masm) {
Label generic_constructor;
if (FLAG_debug_code) {
- // The array construct code is only set for the builtin Array function
which
- // does always have a map.
- __ LoadGlobalFunction(Context::ARRAY_FUNCTION_INDEX, rbx);
- __ cmpq(rdi, rbx);
- __ Check(equal, "Unexpected Array function");
+ // The array construct code is only set for the builtin and internal
+ // Array functions which always have a map.
// Initial map for the builtin Array function should be a map.
__ movq(rbx, FieldOperand(rdi,
JSFunction::kPrototypeOrInitialMapOffset));
// Will both indicate a NULL and a Smi.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
