Revision: 7046
Author: [email protected]
Date: Thu Mar 3 05:36:31 2011
Log: Remove tests for being the normal array constructor from the
ArrayConstructCode builtin.
Review URL: http://codereview.chromium.org/6613016
http://code.google.com/p/v8/source/detail?r=7046
Modified:
/branches/bleeding_edge/src/arm/builtins-arm.cc
/branches/bleeding_edge/src/x64/builtins-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/builtins-arm.cc Thu Mar 3 03:49:03 2011
+++ /branches/bleeding_edge/src/arm/builtins-arm.cc Thu Mar 3 05:36:31 2011
@@ -458,11 +458,8 @@
Label generic_constructor;
if (FLAG_debug_code) {
- // The array construct code is only set for the builtin Array function
which
- // always have a map.
- GenerateLoadArrayFunction(masm, r2);
- __ cmp(r1, r2);
- __ Assert(eq, "Unexpected Array function");
+ // The array construct code is only set for the builtin and internal
+ // Array functions which always have a map.
// Initial map for the builtin Array function should be a map.
__ ldr(r2, FieldMemOperand(r1,
JSFunction::kPrototypeOrInitialMapOffset));
__ tst(r2, Operand(kSmiTagMask));
=======================================
--- /branches/bleeding_edge/src/x64/builtins-x64.cc Thu Mar 3 03:49:03 2011
+++ /branches/bleeding_edge/src/x64/builtins-x64.cc Thu Mar 3 05:36:31 2011
@@ -1280,11 +1280,8 @@
Label generic_constructor;
if (FLAG_debug_code) {
- // The array construct code is only set for the builtin Array function
which
- // does always have a map.
- __ LoadGlobalFunction(Context::ARRAY_FUNCTION_INDEX, rbx);
- __ cmpq(rdi, rbx);
- __ Check(equal, "Unexpected Array function");
+ // The array construct code is only set for the builtin and internal
+ // Array functions which always have a map.
// Initial map for the builtin Array function should be a map.
__ movq(rbx, FieldOperand(rdi,
JSFunction::kPrototypeOrInitialMapOffset));
// Will both indicate a NULL and a Smi.
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev