I like the approach. I saved the temporary ZoneLists and the code for
polymorphic loads can probably share a lot. I think it's fine to have a
separate
helper to handle polymorphic calls since they don't fit the same pattern.
http://codereview.chromium.org/6615014/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/6615014/diff/1/src/hydrogen.cc#newcode3183
src/hydrogen.cc:3183: HInstruction* instr =
BuildStoreNamedGeneric(object, name, value);
Maybe BuildStoreNamedGeneric should return a HStoreNamedGeneric*, and
instr->HasSideEffect() will be always true.
http://codereview.chromium.org/6615014/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
