Reviewers: Vitaly, Message: The vs2008 barfed on same class declared with mixed struct/class keywords.
Also new threading stuff in shell.cc needs WIN32 define, which is not defined
for samples by default. Description: [Isolates] Fix build on 64-bit version of Windows with vs2008 Please review this at http://codereview.chromium.org/6624006/ SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/ Affected files: M SConstruct M src/isolate.h Index: SConstruct =================================================================== --- SConstruct (revision 7051) +++ SConstruct (working copy) @@ -577,7 +577,7 @@ } }, 'arch:ia32': { - 'CPPDEFINES': ['V8_TARGET_ARCH_IA32'], + 'CPPDEFINES': ['V8_TARGET_ARCH_IA32', 'WIN32'], 'LINKFLAGS': ['/MACHINE:X86'] }, 'arch:x64': { Index: src/isolate.h =================================================================== --- src/isolate.h (revision 7051) +++ src/isolate.h (working copy) @@ -918,7 +918,7 @@ // not entered by any thread and can be Disposed. // If the same thread enters the Isolate more then once, the entry_count_ // is incremented rather then a new item pushed to the stack. - struct EntryStackItem { + class EntryStackItem { public: EntryStackItem(PerIsolateThreadData* previous_thread_data, Isolate* previous_isolate, -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
