Reviewers: Dmitry Titov,

Description:
[Isolates] Add missing v8.h includes.

Please review this at http://codereview.chromium.org/6625040/

Affected files:
  M src/arm/lithium-arm.cc
  M src/arm/lithium-codegen-arm.cc
  M src/arm/lithium-gap-resolver-arm.cc
  M src/d8.cc
  M src/gdb-jit.cc
  M src/hydrogen.cc
  M src/ia32/lithium-gap-resolver-ia32.cc
  M src/lithium-allocator.cc
  M src/lithium.cc
  M src/preparser-api.cc
  M src/scanner-base.h


Index: src/arm/lithium-arm.cc
diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc
index 65177d876b4f41856ff0d6d08c2cd0e50c180df0..f044592c86e1d1ed898a5898e4873fd9b7db409b 100644
--- a/src/arm/lithium-arm.cc
+++ b/src/arm/lithium-arm.cc
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
+
 #include "lithium-allocator-inl.h"
 #include "arm/lithium-arm.h"
 #include "arm/lithium-codegen-arm.h"
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index f144104b4442bed679b9ddc9a1c7bc13e8c7b21f..e302fd2e050ab885a964effed9e32f1f665c425b 100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
+
 #include "arm/lithium-codegen-arm.h"
 #include "arm/lithium-gap-resolver-arm.h"
 #include "code-stubs.h"
Index: src/arm/lithium-gap-resolver-arm.cc
diff --git a/src/arm/lithium-gap-resolver-arm.cc b/src/arm/lithium-gap-resolver-arm.cc index 1a2326b748d5a38642d864a6972504bb6f5d9868..02608a695042ea06cc830b972149a8b3b2661ea4 100644
--- a/src/arm/lithium-gap-resolver-arm.cc
+++ b/src/arm/lithium-gap-resolver-arm.cc
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
+
 #include "arm/lithium-gap-resolver-arm.h"
 #include "arm/lithium-codegen-arm.h"

Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index e70c32b7e28af60eff83760eb6e37899e7077577..7de82b759f3b75b93390d1c6c41ef1318fe7468c 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -29,6 +29,8 @@
 #include <stdlib.h>
 #include <errno.h>

+#include "v8.h"
+
 #include "d8.h"
 #include "d8-debug.h"
 #include "debug.h"
Index: src/gdb-jit.cc
diff --git a/src/gdb-jit.cc b/src/gdb-jit.cc
index 5136deddbf7e4aa4713cd32207b51b6c254d6c46..c8dbf5d67e6a9b2e1fce48ecaf1e51464fe52de0 100644
--- a/src/gdb-jit.cc
+++ b/src/gdb-jit.cc
@@ -26,6 +26,7 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 #ifdef ENABLE_GDB_JIT_INTERFACE
+#include "v8.h"
 #include "gdb-jit.h"

 #include "bootstrapper.h"
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 3f08dedc34d348e9704a77fe0b28f4cf104df8a4..016f8910ecbd66952acf7c276ed13afa011495a1 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -25,6 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
 #include "hydrogen.h"

 #include "codegen.h"
Index: src/ia32/lithium-gap-resolver-ia32.cc
diff --git a/src/ia32/lithium-gap-resolver-ia32.cc b/src/ia32/lithium-gap-resolver-ia32.cc index 45c790f3f0d5a35374694b997ad9ecf1450c860b..eabfecc58c6264f81113feebf39c10c7ff429b7a 100644
--- a/src/ia32/lithium-gap-resolver-ia32.cc
+++ b/src/ia32/lithium-gap-resolver-ia32.cc
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
+
 #include "ia32/lithium-gap-resolver-ia32.h"
 #include "ia32/lithium-codegen-ia32.h"

Index: src/lithium-allocator.cc
diff --git a/src/lithium-allocator.cc b/src/lithium-allocator.cc
index 8786bbe5cf010e0bc241fba2647dc52e95043e36..e9bd0b2eaad4b0f674532385e272ae4916511004 100644
--- a/src/lithium-allocator.cc
+++ b/src/lithium-allocator.cc
@@ -25,6 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
 #include "lithium-allocator-inl.h"

 #include "hydrogen.h"
Index: src/lithium.cc
diff --git a/src/lithium.cc b/src/lithium.cc
index e829f2f049a06579f57a29aecefebef5eb8e9f77..aeac2db562ab01296b2c63680cf05a1ba49d8fb2 100644
--- a/src/lithium.cc
+++ b/src/lithium.cc
@@ -25,6 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "v8.h"
 #include "lithium.h"

 namespace v8 {
Index: src/preparser-api.cc
diff --git a/src/preparser-api.cc b/src/preparser-api.cc
index 3817935f8f8050f5327ff3a9fa964af1a2cb88cd..f6d1a5a4d334a429562d700fba623efba215fbd1 100644
--- a/src/preparser-api.cc
+++ b/src/preparser-api.cc
@@ -26,6 +26,9 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 #include "../include/v8-preparser.h"
+
+#include "v8.h"
+
 #include "globals.h"
 #include "checks.h"
 #include "allocation.h"
Index: src/scanner-base.h
diff --git a/src/scanner-base.h b/src/scanner-base.h
index ddad18643ab4c998d2d26b6a66f7e812bc56d91e..7203569770aa7987e0a8b73e1e2322b320c55303 100644
--- a/src/scanner-base.h
+++ b/src/scanner-base.h
@@ -246,6 +246,8 @@ class LiteralBuffer {
   bool is_ascii_;
   int position_;
   Vector<byte> backing_store_;
+
+  DISALLOW_COPY_AND_ASSIGN(LiteralBuffer);
 };




--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to