http://codereview.chromium.org/6628012/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6628012/diff/1/src/hydrogen.cc#newcode3245 src/hydrogen.cc:3245: if (instr->HasSideEffects()) { On 2011/03/07 11:29:47, fschneider wrote:
HasSideEffects() is always true for HStoreNamedGeneric.
But this code shouldn't rely on assuming the type returned by the BuildStoreNamedGeneric helper, or assume a property of that instruction. Eventually I'll get rid of HGraphBuilder::AddSimulate and have AddInstruction or else the constructor responsible for capturing the environment. Until then and since things are changing, it seems nicer to assume as little as possible. http://codereview.chromium.org/6628012/diff/1/src/hydrogen.cc#newcode3571 src/hydrogen.cc:3571: } On 2011/03/07 11:29:47, fschneider wrote:
Remove extra space.
Thanks. http://codereview.chromium.org/6628012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
