LGTM
http://codereview.chromium.org/6625054/diff/1/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/6625054/diff/1/src/type-info.cc#newcode330 src/type-info.cc:330: for (int i = 0; i < length; i++) { You may want a loop HandleScope to avoid using too many handles if length is long. Can it be long? http://codereview.chromium.org/6625054/diff/1/src/type-info.cc#newcode373 src/type-info.cc:373: dictionary_ = Factory::DictionaryAtNumberPut(dictionary_, It seems almost all branches end in a dictionary put with the same dictionary and position. Could you just remember the value in a variable, and have one common put-call at the end? http://codereview.chromium.org/6625054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
