LGTM
http://codereview.chromium.org/6621042/diff/1/src/debug.cc File src/debug.cc (right): http://codereview.chromium.org/6621042/diff/1/src/debug.cc#newcode1007 src/debug.cc:1007: // they are in a FixedArray. The second part of the comment should maybe be moved to just before line 1011 for a better context. http://codereview.chromium.org/6621042/diff/1/src/handles.h File src/handles.h (right): http://codereview.chromium.org/6621042/diff/1/src/handles.h#newcode270 src/handles.h:270: StrictModeFlag strict_mode); Yey! http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc File src/liveedit.cc (right): http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc#newcode290 src/liveedit.cc:290: no_failure = SetElement(array_, Add a comment saying that we never set element accessors in the debug context. http://codereview.chromium.org/6621042/diff/1/src/liveedit.cc#newcode303 src/liveedit.cc:303: kNonStrictMode); Are we sure we don't get any warnings from this assignment in release mode? On any platform? The assigned value is unused. http://codereview.chromium.org/6621042/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
