LGTM
http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#newcode4108 src/arm/code-stubs-arm.cc:4108: // C function for integer exponents. Maybe add a comment that heapnumber is callee saved. http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#newcode4123 src/arm/code-stubs-arm.cc:4123: __ mov(result, heapnumber); I think it would be fine to just use r0 here and drop the variable "result". http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#newcode4136 src/arm/code-stubs-arm.cc:4136: // double exponents. Ditto. http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#newcode4151 src/arm/code-stubs-arm.cc:4151: __ mov(result, heapnumber); Ditto. http://codereview.chromium.org/6613015/diff/6001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6613015/diff/6001/src/arm/lithium-codegen-arm.cc#newcode2653 src/arm/lithium-codegen-arm.cc:2653: __ eor(scratch, scratch, Operand(scratch)); On ARM just using mov(scratch, Operand(0)) should be fine for zeroing a register. http://codereview.chromium.org/6613015/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
