LGTM.
http://codereview.chromium.org/6647012/diff/5001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6647012/diff/5001/src/x64/lithium-codegen-x64.cc#newcode261 src/x64/lithium-codegen-x64.cc:261: JumpTableEntry* info = &jump_table_[i]; Agree. http://codereview.chromium.org/6647012/diff/5001/src/x64/lithium-codegen-x64.h File src/x64/lithium-codegen-x64.h (right): http://codereview.chromium.org/6647012/diff/5001/src/x64/lithium-codegen-x64.h#newcode247 src/x64/lithium-codegen-x64.h:247: Label label_; Kevin also reminded me that struct fields don't need the "_" suffix, so while you're at it ... :) http://codereview.chromium.org/6647012/diff/5003/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6647012/diff/5003/src/x64/lithium-codegen-x64.cc#newcode545 src/x64/lithium-codegen-x64.cc:545: jump_table_.Add(entry); If the JumpTableEntry constructor was explicit, this wouldn't typecheck. You'll need .Add(JumpTableEntry(address)) http://codereview.chromium.org/6647012/diff/5003/src/x64/lithium-codegen-x64.h File src/x64/lithium-codegen-x64.h (right): http://codereview.chromium.org/6647012/diff/5003/src/x64/lithium-codegen-x64.h#newcode244 src/x64/lithium-codegen-x64.h:244: inline JumpTableEntry(Address address) Whoops, we forgot the "explicit" here. I'm surprised it lints. http://codereview.chromium.org/6647012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
